-
Notifications
You must be signed in to change notification settings - Fork 9
refactor: De-complexify 'count' metric #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smudge
wants to merge
1
commit into
smudge/stack/7
Choose a base branch
from
smudge/stack/8
base: smudge/stack/7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that `live_count_grouped` is already necessary for computing all the other live queue metrics, we can reduce the work on MySQL by running `failed_count_grouped` (and filtering the scan down to fewer rows) instead of an entire count against the table. stack-info: PR: #97, branch: smudge/stack/8
smudge
added a commit
that referenced
this pull request
Feb 10, 2026
Given that `live_count_grouped` is already necessary for computing all the other live queue metrics, we can reduce the work on MySQL by running `failed_count_grouped` (and filtering the scan down to fewer rows) instead of an entire count against the table. stack-info: PR: #97, branch: smudge/stack/8
7450dfb to
e7d2cde
Compare
3a68af0 to
72f7d0b
Compare
This was referenced Feb 10, 2026
smudge
added a commit
that referenced
this pull request
Feb 10, 2026
Given that `live_count_grouped` is already necessary for computing all the other live queue metrics, we can reduce the work on MySQL by running `failed_count_grouped` (and filtering the scan down to fewer rows) instead of an entire count against the table. stack-info: PR: #97, branch: smudge/stack/8
e7d2cde to
6fbbb07
Compare
Open
6fbbb07 to
4c85e14
Compare
4c85e14 to
d2a7765
Compare
7561419 to
c81508f
Compare
smudge
added a commit
that referenced
this pull request
Feb 10, 2026
Given that `live_count_grouped` is already necessary for computing all the other live queue metrics, we can reduce the work on MySQL by running `failed_count_grouped` (and filtering the scan down to fewer rows) instead of an entire count against the table. stack-info: PR: #97, branch: smudge/stack/8
d2a7765 to
aa7ebef
Compare
c81508f to
0484f28
Compare
smudge
added a commit
that referenced
this pull request
Feb 10, 2026
Given that `live_count_grouped` is already necessary for computing all the other live queue metrics, we can reduce the work on MySQL by running `failed_count_grouped` (and filtering the scan down to fewer rows) instead of an entire count against the table. stack-info: PR: #97, branch: smudge/stack/8
aa7ebef to
7f7ebd6
Compare
0484f28 to
595820a
Compare
smudge
added a commit
that referenced
this pull request
Feb 11, 2026
Given that `live_count_grouped` is already necessary for computing all the other live queue metrics, we can reduce the work on MySQL by running `failed_count_grouped` (and filtering the scan down to fewer rows) instead of an entire count against the table. stack-info: PR: #97, branch: smudge/stack/8
7f7ebd6 to
44b050b
Compare
595820a to
70a7521
Compare
44b050b to
34bdbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
refactor: De-complexify 'count' metric
Given that
live_count_groupedis already necessary for computing allthe other live queue metrics, we can reduce the work on MySQL by running
failed_count_grouped(and filtering the scan down to fewer rows)instead of an entire count against the table.