test: Rework monitor coverage to avoid dups #91
Merged
+572
−541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smudge
force-pushed
the
smudge/stack/1
branch
from
3d9cd4f to
7fc4450
Compare
smudge
force-pushed
the
smudge/stack/2
branch
from
a08ff7e to
197d59a
Compare
This was referenced Feb 10, 2026
smudge
force-pushed
the
smudge/stack/2
branch
from
197d59a to
1881eca
Compare
Open
This is a test-only change that improves the way that query snapshotting is done for the monitor process. Previously, each metric was given its own example context, testing its queries in isolation. However, in practice, the monitor does not run this way, and it intentionally memoizes query results in a way that was not receiving sufficient test coverage! With this PR, monitor queries are dumped out into a single snapshot, delineated by a few text dividers for readability by humans (& better hinting for the git differ). /no-platform stack-info: PR: #91, branch: smudge/stack/2
smudge
force-pushed
the
smudge/stack/2
branch
from
1881eca to
e5089e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
test: Rework monitor coverage to avoid dups
This is a test-only change that improves the way that query snapshotting
is done for the monitor process.
Previously, each metric was given its own example context, testing its
queries in isolation. However, in practice, the monitor does not run
this way, and it intentionally memoizes query results in a way that was
not receiving sufficient test coverage!
With this PR, monitor queries are dumped out into a single snapshot,
delineated by a few text dividers for readability by humans (& better
hinting for the git differ).
/no-platform