-
Notifications
You must be signed in to change notification settings - Fork 10
refactor: Simpler priority case statement #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty self-explanatory -- the performance impact is probably de minimis, but the readability is certainly improved, IMO! /no-platform stack-info: PR: #93, branch: smudge/stack/4
8a56d8d to
8fd2fb0
Compare
2281393 to
8c56d06
Compare
This was referenced Feb 10, 2026
8fd2fb0 to
f27939b
Compare
Merged
f27939b to
1be44a8
Compare
d20ff77 to
cb0ef67
Compare
smudge
added a commit
that referenced
this pull request
Feb 10, 2026
This is pretty self-explanatory -- the performance impact is probably de minimis, but the readability is certainly improved, IMO! /no-platform stack-info: PR: #93, branch: smudge/stack/4
1be44a8 to
01bd727
Compare
01bd727 to
65fa278
Compare
samandmoore
approved these changes
Feb 11, 2026
Member
samandmoore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domainlgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
refactor: Simpler priority case statement
This is pretty self-explanatory -- the performance impact is probably
de minimis, but the readability is certainly improved, IMO!
/no-platform