Conversation
a-cires
previously requested changes
Feb 3, 2026
Contributor
a-cires
left a comment
a-cires
left a comment
There was a problem hiding this comment.
Minor formatting changes requested, remove comments, etc.
src/subsystems/navigation/athena_planner/launch/nav2_nodes.launch.py
Outdated
Show resolved
Hide resolved
mdurrani808
approved these changes
Feb 3, 2026
Collaborator
mdurrani808
left a comment
mdurrani808
left a comment
There was a problem hiding this comment.
overall looks good, minor nits
src/subsystems/navigation/athena_planner/behavior_trees/aruco_detection_navigation.xml
Show resolved
Hide resolved
src/subsystems/navigation/athena_planner/plugins/nav_selector_node.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes nav selection from gui through /nav_mode topic and switches to the corresponding subtree.