Conversation
a-cires
requested changes
Feb 1, 2026
Contributor
a-cires
left a comment
a-cires
left a comment
There was a problem hiding this comment.
Any files that need to be added as executables, binaries, or system daemons need to include "umdloop" in the file's title, so that it is easily identifiable at a glance when looking through system files.
a-cires
reviewed
Feb 2, 2026
| if systemctl is-enabled umdloop_can.service &>/dev/null; then | ||
| echo "[WARN] CAN service already enabled" | ||
| systemctl restart can.service | ||
| ip link set can0 down 2>/dev/null || true |
Contributor
There was a problem hiding this comment.
Technically, this line will run twice. Once here, and a second time when the daemon is reset.
Not a big deal either way, just thought you should know.
a-cires
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves some scripts over from setup-tools and adds the jetson setup script.
Note not actually tested, likely just trial by fire.