Skip to content

refactor: 응답에서 refresh token은 제외하여 전달하도록 #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whqtker wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −2
Open

refactor: 응답에서 refresh token은 제외하여 전달하도록 #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/example/solidconnection/auth/dto/SignInResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

import com.example.solidconnection.auth.domain.AccessToken;
import com.example.solidconnection.auth.domain.RefreshToken;
import com.fasterxml.jackson.annotation.JsonIgnore;

public record SignInResponse(
String accessToken,
String refreshToken
@JsonIgnore String refreshToken
) {

public static SignInResponse of(AccessToken accessToken, RefreshToken refreshToken) {
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/com/example/solidconnection/auth/dto/oauth/OAuthSignInResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package com.example.solidconnection.auth.dto.oauth;

import com.fasterxml.jackson.annotation.JsonIgnore;

public record OAuthSignInResponse(
boolean isRegistered,
String accessToken,
String refreshToken) implements OAuthResponse {
@JsonIgnore String refreshToken) implements OAuthResponse {
Copy link
Contributor

@sukangpunch sukangpunch Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 생각에 Response 객체는 http 응답 본문을 나타내는 객체라고 생각하여 명확하게 엑세스 토큰과 isRegisterd 필드만 담은 response dto를 따로 두어 컨트롤러에서 매핑하여 리턴하는 방식은 어떠신가요?


}
Loading