refactor: 응답에서 refresh token은 제외하여 전달하도록#646
Open
whqtker wants to merge 1 commit intosolid-connection:developfrom
Open
refactor: 응답에서 refresh token은 제외하여 전달하도록#646whqtker wants to merge 1 commit intosolid-connection:developfrom
whqtker wants to merge 1 commit intosolid-connection:developfrom
Conversation
whqtker
requested review from
Gyuhyeok99,
Hexeong,
JAEHEE25,
lsy1307,
sukangpunch and
wibaek
as code owners
Walkthrough이 변경사항은 두 개의 응답 DTO 클래스에 JSON 직렬화 제외 처리를 추가합니다.
두 변경사항 모두 refreshToken을 JSON 응답에서 제외하면서도 객체 내부에는 필드를 유지합니다. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sukangpunch
reviewed
Feb 7, 2026
Contributor
sukangpunch
left a comment
sukangpunch
left a comment
There was a problem hiding this comment.
고생하셨습니다!! 궁금한 점 리뷰 달았습니다.
| boolean isRegistered, | ||
| String accessToken, | ||
| String refreshToken) implements OAuthResponse { | ||
| @JsonIgnore String refreshToken) implements OAuthResponse { |
Contributor
There was a problem hiding this comment.
제 생각에 Response 객체는 http 응답 본문을 나타내는 객체라고 생각하여 명확하게 엑세스 토큰과 isRegisterd 필드만 담은 response dto를 따로 두어 컨트롤러에서 매핑하여 리턴하는 방식은 어떠신가요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
로그인 응답에서 refresh token은 제외하도록
@JsonIgnore어노테이션을 붙였습니다.아예 해당 필드는 제거할 수는 없는게, 응답 DTO에서 refresh token 필드를 통해 쿠키를 설정하고 있습니다. 따라서 프론트에게 전달만 되지 않도록 설정했습니다.
더 좋은 방법이 있다면 말씀해주세요 ~
특이 사항
리뷰 요구사항 (선택)