prioritize attribute extraction over html content.#120
Closed
anilanar wants to merge 1 commit intorubenv:masterfrom
Closed
prioritize attribute extraction over html content.#120anilanar wants to merge 1 commit intorubenv:masterfrom
anilanar wants to merge 1 commit intorubenv:masterfrom
Conversation
Author
|
Based on failing test: If we want |
|
Has there been any more work on this issue? We are running into the same problem when trying to translate placeholders on nodes that have html content. |
|
I think I fixed it here |
Author
|
@Runn1ng Hey thanks, but repo owner has not answered yet. |
Contributor
|
It helps to include a test for the behavior you want to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick fix based on my question in the main repo: rubenv/angular-gettext#246
Assuming we have
tooltipattribute added into grunt configoptions.attributes:And we can combine
attr-n,attr-plural,attr-contextandattr-commentwith translate, but it is not related to this fix:As you can see, I have used
$tooltipCountinstead of$countfor tooltip attribute because they use the same scope and those properties of scope would override each other's value if they had the same name. Also this example assumes someone created a custom directive fortooltipattribute.