Fix value priority order for custom translation attribute extraction#137
Open
bartbutler wants to merge 3 commits intorubenv:masterfrom
Open
Fix value priority order for custom translation attribute extraction#137bartbutler wants to merge 3 commits intorubenv:masterfrom
bartbutler wants to merge 3 commits intorubenv:masterfrom
Conversation
When using a custom directive on an attribute, the extracted string should default to the value of the attribute, and if not present, fallback to the HTML inside the tag.
Author
|
Whoops, this is a repeat of #120, though perhaps slightly cleaner. Sorry. |
Author
|
@rubenv, forgive my ignorance, but the tests that fail here seem to be broken. For instance, there is stuff like this:
From the current documentation (and logic) I would expect that if the user wanted to translate 'Translate this' they would use:
|
Author
|
Made a special case for attribute translate = "translate", as I imagine there are existing codebases using this syntax. |
Contributor
|
You should include a test for this change. Then maybe it gets attention from @rubenv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom directive on an attribute, the extracted string should default to the value of the attribute, and if not present, fallback to the HTML inside the tag. For example, if I want to translate all my 'tooltip' attributes, and have some HTML like this:
<span tooltip="translate this">Not this</span>The old extract.js would extract "Not this" instead. This change fixes this, while allowing "Not this" to be translated if desired by giving the attribute no value.