Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
==========================================
- Coverage 90.89% 90.88% -0.02%
==========================================
Files 25 25
Lines 4340 4334 -6
==========================================
- Hits 3945 3939 -6
Misses 395 395
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type annotation improvements:
Locale.parseto always return aLocale(this fixes type issues in multiple places where the return type is assumed to not be None)type: ignorein certain places in core.py and numbers.pyNote: Changing
Locale.parseto always return aLocalesimplifies the logic, but it also can potentially be a breaking change if people are relying on passingNonenot raising an exception. It is a bit of a stretch though, since passingNonehas no functional effect in the use of the lib.These changes have been separated from #961