Make LocaleDataDict Generic#961
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
==========================================
- Coverage 90.91% 90.90% -0.02%
==========================================
Files 25 25
Lines 4350 4353 +3
==========================================
+ Hits 3955 3957 +2
- Misses 395 396 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
That's a great change – I don't think it messes up any valid downstream workflows. However seeing as that retval was added here 8b7c5e1 in a commit that talks about likely subtag resolving, could you make sure that it doesn't affect that functionality? I think we might need to do |
As far as I can tell, there aren't any locations in the lib that expect the return type of The places that check for locale being It could raise a different exception from the standard |
akx
left a comment
There was a problem hiding this comment.
I'm a little wary about the LocaleDataDict changes... The numbers changes look alright though, can you break them out into a separate PR?
d1847f8 to
2171b6c
Compare
This reverts commit 47ef03b.
Type annotation improvements:
LocaleDataDictuseTypeVars so that the key and value types can be annotated for each instanceLocaleDataDictLocaleDataDictOther changes moved to #966