Summarize the max severity at the top of logs, star all max-severity logs#3163
Summarize the max severity at the top of logs, star all max-severity logs#3163kainino0x wants to merge 2 commits intogpuweb:mainfrom
Conversation
7b9a184 to
be4982d
Compare
|
So that's better than it was because it at least it says there was an exception but at a glance it looks like I still need to scroll down 30 screens to see the real error, right? (sorry, out of the office and on slow internet so not easy to check) |
|
I would like to ask about the sorting. Maybe this would have helped but, here for example is a report before this change
vs after this change
vs the change suggested in #3156
In the first one I've mislead myself multiple times into thinking there was an implementation error when in fact it was a CTS error. The 2nd one helps in that I can see in small print that there was an exception but I still have to scroll down, possibly many pages, to see it. In the 3rd the issue is right at the top. Can we put in both? Is there something wrong with the sorting? Should I add official categories to the sort one to make it more palatable or does sorting have issues? |
|
We can do both. I wanted to have a solution that would apply to more than just standalone since a lot of people don't use it. But since yours does only affect standalone it won't cause any extra log file spew so I think it would be OK. That said I think this change is going to break |
Wait, never mind, that was a previous revision of this PR. I made it not do that. |



This is an alternative way of highlighting info to #3156. It avoids printing logs multiple times since we have problems with some tests printing too much. It also applies to all runtimes, not just standalone, so that's more important.
Issue: None
Requirements for PR author:
All missing test coverage is tracked with "TODO" or.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
Tests are properly located in the test tree.Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.When landing this PR, be sure to make any necessary issue status updates.