Compat image copy test depth stencil#3192
Merged
greggman merged 2 commits intogpuweb:mainfrom Nov 30, 2023
Merged
Conversation
greggman
requested review from
SenorBlanco and
shrekshao
and removed request for
SenorBlanco
shrekshao
approved these changes
Nov 30, 2023
…de. (gpuweb#3140)" (gpuweb#3161)" This reverts commit 0e06340. These tests test writeBuffer, copyBufferToTexture, and copyTextureToBuffer as it says at the top of the file. They should not have been disabled for textures that don't support copyTextureToBuffer. For those cases they use rendering compare results.
greggman
force-pushed
the
compat-image-copy-test-depth-stencil
branch
from
22e258f to
6a6cffd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix depth stencil image_copy tests for compat.
This was another case where the fact that the CTS reports the actual cause of failure long below the list of failed expectations was misleading to me. 2 PRs are in to fix that issue so it can start putting the cause of failure at the top.
#3163
#3156
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.