test(check.rb): add #extra_args instruction#521
Draft
tueda wants to merge 1 commit intoform-dev:masterfrom
Draft
test(check.rb): add #extra_args instruction#521tueda wants to merge 1 commit intoform-dev:masterfrom
tueda wants to merge 1 commit intoform-dev:masterfrom
Conversation
By using this instruction, one can add extra command-line arguments to be passed to FORM. Example: #extra_args -w2
Collaborator
|
I would say it is probably best to run the entire set of tests with both w2 and w4. I am not sure on the limits of github's runners. The valgrind tests are taking the majority of the time at the moment (and those should probably be run with both w2 and w4 as well, since different code runs...). #520 manifests even for very trivial input. Maybe there is even something in the current set of tests that doesn't work with w2... |
Collaborator
Author
|
You are right. Adding |
Collaborator
Author
|
This patch is not needed for now, but we may revisit it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably the simplest approach to resolve the issue (testing
tform -w2) discussed in (#520 (comment)).This patch adds a new special instruction
#extra_argsthat can be used to add extra command-line arguments to be passed to FORM. For exampleleads to run
tform -w4 -w2 1.frmfor testing TFORM.Instead of adding
#extra_args, other options would be:-w2and then with-w4.-w2and then with-w4.