ci: add test jobs for tform/tvorm -w2#522
Merged
tueda merged 1 commit intoform-dev:masterfrom May 21, 2024
Merged
Conversation
Collaborator
Author
|
Contrary to my expectations, for some reason all tests passed for this PR, though some of them failed for my fork. It's strange... |
Add a variable "nthreads" to the configurations of "check", "valgrind-check", "coverage" and "check-i386" jobs. This variable specifies the number of threads in tform/tvorm jobs. Now "-w2" is tested in addition to the default "-w4".
Collaborator
|
Some of those seem not unexpected if you didn't have #520 in your fork. Things seem OK now, also in your fork? What changed there? |
Collaborator
Author
|
You are right. After correctly rebasing with the upstream branch, it now works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds test jobs with
-w2to CI. See also #520 (comment) and another solution to test-w2by adding#extra_args#521.Currently, it gives 5 test failures:
Issue178 (fixes.frm:1651)Issue313 (fixes.frm:2294)Issue336_1 (fixes.frm:2355)Issue336_2 (fixes.frm:2417)Issue468 (fixes.frm:2684)Moreover, Forcer doesn't work with
-w2.Question: is it OK to merge it? Or, do we want to fix these failures before the merge?