The password provided to configure shouldn't be echo'd.#244
The password provided to configure shouldn't be echo'd.#244areese wants to merge 2 commits intodatabricks:masterfrom
Conversation
areese
commented
Jul 8, 2019
areese
commented
areese
force-pushed
the
oss_patch_hide_password
branch
from
da10f3d to
a629bd5
Compare
|
This is very similar to: #123 |
| config = ProfileConfigProvider(profile).get_config() or DatabricksConfig.empty() | ||
| host = click.prompt(PROMPT_HOST, default=config.host, type=_DbfsHost()) | ||
| username = click.prompt(PROMPT_USERNAME, default=config.username) | ||
| password = 'stdin' |
There was a problem hiding this comment.
What if my password is stdin? I know this password is probably not allowed in most sign up workflows in Databricks but I'd rather not special case this password..
Can we just add a flag called read_password_from_stdin or something?
There was a problem hiding this comment.
excellent point, let me rework this that way.
How about empty password? Would that be an ok choice or would you rather use a flag?
There was a problem hiding this comment.
I think a flag is probably just the cleanest way.
areese
force-pushed
the
oss_patch_hide_password
branch
from
b723e68 to
57facd4
Compare
Add a --stdin option to configure, so that the password will always be read from stdin instead of stored in a file.
areese
force-pushed
the
oss_patch_hide_password
branch
from
57facd4 to
44d3ba4
Compare
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
- Coverage 82.95% 82.63% -0.32%
==========================================
Files 31 31
Lines 2047 2062 +15
==========================================
+ Hits 1698 1704 +6
- Misses 349 358 +9
Continue to review full report at Codecov.
|
|
I'm going to close this. I ended up with a new patch to hide the token, and I never ended up using the stdin option after all. |
3 participants
