Merged
Conversation
areese
force-pushed
the
oss_patch_add_debug_flag
branch
from
834b586 to
6ad0646
Compare
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 82.87% 82.95% +0.07%
==========================================
Files 31 31
Lines 2038 2047 +9
==========================================
+ Hits 1689 1698 +9
Misses 349 349
Continue to review full report at Codecov.
|
andrewmchen
reviewed
Jul 11, 2019
Add a --stdin option to configure, so that the password will always be read from stdin instead of stored in a file.
If --debug is used or if DATABRICKS_DEBUGGING is set in the environment the entire contents of the http requests will be printed to stdout.
areese
force-pushed
the
oss_patch_add_debug_flag
branch
from
470b0bc to
9834e6d
Compare
Move all debug logic into ContextObject.set_debug which is called when --debug is sent to any command
Contributor
Author
|
@andrewmchen Updated, using the --debug flag and ContextObject made the code a lot cleaner. |
andrewmchen
reviewed
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #244