Prefer Decimal over float in utils#30
Open
mhluongo wants to merge 1 commit intoblockcypher:masterfrom
Open
Conversation
|
Thanks @mhluongo and good call, this is better. Would you mind adding test coverage for these changes? I'm requiring test coverage of all new PRs. I realize it's a bit unfair that you're improving something with no test coverage and it requires test coverage in order to be merged. If it's a pain, I'm happy to write the tests for you. Thanks again @mhluongo! |
Contributor
Author
|
I'll see if I have some time in the next couple days. |
|
Thanks @mhluongo ! |
|
still not merged yet ...... |
Contributor
|
I think that would still require some test coverage to be sure this is not breaking anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In financial applications, it's important to avoid floating-precision math. Instead, stick with integers (and either don't divide, or round conscientiously) or use a good arbitrary-precision math library.
In Python, that library is
decimal. It supports all the operators you'd expect, properly "coerces" integers intoDecimals, and throws an exception if fixed-precision and floating-point math mix.I didn't go through the whole code base- I just fixed a couple things in utils I wanted to use. The tests appear to be unaffected, though I'm not sure they have the coverage for a change like this, so use caution when merging.