updated utils.py and tests for using Decimal instead of float#132
Open
frier17 wants to merge 2 commits intoblockcypher:masterfrom
Open
updated utils.py and tests for using Decimal instead of float#132frier17 wants to merge 2 commits intoblockcypher:masterfrom
frier17 wants to merge 2 commits intoblockcypher:masterfrom
Conversation
Contributor
Author
|
@quentinlesceller please can you help with a review on this? I believe it addresses earlier concern over the use of Decimal instead of floats for unit conversions raised in PR #30 . Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated utils.py to use Decimal instead of float in addressing previous PR by @mhluongo PR #30 .
Updated test for changes in
to_base_unit,from_base_unit, andformat_crypto_unitsfunctions.Modified functions can take both numeric and string values as quantity of cryptocurrency and appropriately parse values to Decimal for processing.