Conversation
mcserep
added
Kind: Refactor 🔃
Plugin: C++
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the LLVM version to v15 to support Ubuntu 22.04, cherry-picking changes from an earlier branch. Key changes include updating the file inclusion callback signature in both header and source files to use clang::Optionalclang::FileEntryRef, revising dependency documentation for LLVM v15, and updating CI configuration to reflect the new LLVM/Clang directories.
Reviewed Changes
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/cpp/parser/src/ppincludecallback.h | Updated the callback parameter from a raw pointer to an Optional reference. |
| plugins/cpp/parser/src/ppincludecallback.cpp | Adjusted the parameter type accordingly in the inclusion directive. |
| plugins/cpp/parser/src/clangastvisitor.h | Minor formatting changes without affecting logic. |
| doc/deps.md | Updated dependency references from LLVM/Clang v11 to v15. |
| .github/workflows/ci.yml | Updated CI LLVM/Clang directory paths to point to LLVM/Clang v15. |
Files not reviewed (6)
- .github/scripts/ubuntu-20.04/setup_build.sh: Language not supported
- .github/scripts/ubuntu-22.04/setup_build.sh: Language not supported
- .gitlab/build-deps.sh: Language not supported
- docker/dev/Dockerfile: Language not supported
- docker/runtime/Dockerfile: Language not supported
- docker/web/Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
plugins/cpp/parser/src/ppincludecallback.h:41
- Ensure that all call sites and implementation logic using the File parameter are updated to handle clang::Optionalclang::FileEntryRef appropriately, replacing assumptions of a guaranteed File pointer.
clang::Optional<clang::FileEntryRef> File,
plugins/cpp/parser/src/ppincludecallback.cpp:64
- Verify that the inclusion directive handling in this function correctly accommodates the Optional type in place of a raw pointer, ensuring proper null/empty checks are implemented if needed.
clang::Optional<clang::FileEntryRef>,
# Conflicts: # .github/scripts/ubuntu-20.04/setup_build.sh # doc/deps.md
Collaborator
Author
|
Resolved merge conflicts with #792. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we dropped Ubuntu 20.04 support recently, this PR cherry-picks LLVM15 upgrade from #637, as Ubuntu 22.04 has native support for it.