Closed
Conversation
Collaborator
|
Support for Ubuntu 20.04 has been dropped recently (see #792) and LLVM was upgraded to v15 (see #791), as it was already implemented as part of #637. Now I have rebased and updated this PR accordingly to update the codebase for LLVM v19. I don't think we will merge this in the near future, as even Ubuntu 24.04 does not have LLVM v19 in its standard package repository and the original intention to upgrade LLVM to the newest available version was hunting a macOS specific bug, but it was not solved with LLVM v19 either. Therefore I will close this PR now, but we can look this up once we upgrade to LLVM v19, if that makes the migration easier. Note: documentation and CI upgrades are missing from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements LLVM 19, clang-19 support. The changes are not backwards compatible, meaning it no longer compiles with older LLVM.
Upgraded dependencies:
1.86.0(current Boost version 1.74.0 does not compile with clang-19)17(required by clang-19)Prerequisites
The new Boost version is not in the Ubuntu 22.04 repositories, it needs to be compiled from source.
Download from https://www.boost.org/users/download/, steps:
LLVM 19 is also not in the repositories.
Download from https://apt.llvm.org/, steps:
Compiling CodeCompass
Configure CMake with these flags:
We may encounter the following error:
This can be resolved by
installing LLVM-18removing the following packages:Finally, CodeCompass should build without errors.
I also successfully parsed the
gtestC++ project.