Skip to content

Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayogit1 wants to merge 4 commits into
base: main
Choose a base branch
from
+64 −24
Open

Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls #1141

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f7290f
Completd Form for Task 1
Ayogit1 Jan 24, 2026
d1f86e5
Merge branch 'CodeYourFuture:main' into Form-Control---Task1
Ayogit1 Jan 28, 2026
cf2608b
Merge branch 'CodeYourFuture:main' into Form-Control---Task1
Ayogit1 Feb 5, 2026
a647e7a
Update index.html
Ayogit1 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 64 additions & 24 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,67 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<style>
body {background-color: powderblue;}
h1 {color: blue;}
</style>
<title>Shirt Order Form</title>
</head>

<body>

<main>
<form action="/my-handling-form-page" method="post">
<p>Please complete all required (*) fields.</p>

<p>
<label for="name">What is your name?*</label>
<input type="text" id="name" name="user_name" required>
</p>

<p>
<label for="mail">What is your email?*</label>
<input type="email" id="mail" name="user_email" required>
<small>Format: name1@nnn.com</small>
</p>

<fieldset>
<legend>What colour of shirt do you want?*</legend>
<input type="radio" required name="colour" id="r1" value="Green">
<label for="r1">Green</label>

<input type="radio" required name="colour" id="r2" value="Red">
<label for="r2">Red</label>

<input type="radio" required name="colour" id="r3" value="Blue">
<label for="r3">Blue</label>
</fieldset>

<fieldset>
<legend>What size of shirt do you want?*</legend>
<input type="radio" required name="size" id="r4" value="XS">
<label for="r4">XS</label>

<input type="radio" name="size" id="r5" value="S">
<label for="r5">S</label>

<input type="radio" name="size" id="r6" value="M">
<label for="r6">M</label>

<input type="radio" name="size" id="r7" value="L">
<label for="r7">L</label>

<input type="radio" name="size" id="r8" value="XL">
<label for="r8">XL</label>

<input type="radio" name="size" id="r9" value="XXL">
<label for="r9">XXL</label>
Comment on lines 44 to 60
Copy link
Contributor

@cjyuan cjyuan Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These radio buttons belong to the same button group. So it is not necessary to use required on every radio buttons.

Copy link
Author

@Ayogit1 Ayogit1 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted! I used one of the videos in the course link to fix this.

Copy link
Author

@Ayogit1 Ayogit1 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you help me understand the ask in your comments below?

(1) Your PR couldn't be matched to an assignment in this module - what do you want me to focus on to match it to an assignment in this module?

(2)Please check its title is in the correct format, and that you only have one PR per assignment - I have corrected the title, please let me know your expectations here. Only one PR exists for this task.

(3)If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). - PR is coursework.

(4) If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above - I already added the 'Needs Review' label. If not seen, please let me know where to focus on to fix it.

Copy link
Contributor

@cjyuan cjyuan Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not have these problems. Those messages only applied to your closed PR.

In the previous PR, your titled your PR "... | Sprint 1 | Form Controls" instead of "... | Sprint 2 | Form Controls".
That alone indirectly cause the bot to generate the messages you mentioned in (2), (3), (4).

</fieldset>

</form>
</main>

</body>
</html>