Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls#1141
Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls#1141Ayogit1 wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ayogit1
added
the
Needs Review
|
@cjyuan, I closed the previous PRs as I could not change the title. |
|
Can you address the inline comments I left on your previous PR? #1044 |
| <input type="radio" required name="size" id="r4" value="XS"> | ||
| <label for="r4">XS</label> | ||
|
|
||
| <input type="radio" required name="size" id="r5" value="S"> | ||
| <label for="r5">S</label> | ||
|
|
||
| <input type="radio" required name="size" id="r6" value="M"> | ||
| <label for="r6">M</label> | ||
|
|
||
| <input type="radio" required name="size" id="r7" value="L"> | ||
| <label for="r7">L</label> | ||
|
|
||
| <input type="radio" required name="size" id="r8" value="XL"> | ||
| <label for="r8">XL</label> | ||
|
|
||
| <input type="radio" required name="size" id="r9" value="XXL"> | ||
| <label for="r9">XXL</label> |
There was a problem hiding this comment.
These radio buttons belong to the same button group. So it is not necessary to use required on every radio buttons.
There was a problem hiding this comment.
Noted! I used one of the videos in the course link to fix this.
There was a problem hiding this comment.
Please can you help me understand the ask in your comments below?
(1) Your PR couldn't be matched to an assignment in this module - what do you want me to focus on to match it to an assignment in this module?
(2)Please check its title is in the correct format, and that you only have one PR per assignment - I have corrected the title, please let me know your expectations here. Only one PR exists for this task.
(3)If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). - PR is coursework.
(4) If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above - I already added the 'Needs Review' label. If not seen, please let me know where to focus on to fix it.
cjyuan
added
Reviewed
Removed multiple 'Required' since it is not necessary to use required on every radio button in the same group.
Ayogit1
added
Needs Review
2 participants
Learners, PR Template
Self checklist
Changelist
This PR contains the completed work on the Form Controls
Questions