Skip to content

London | Jan-26 | Xuanming Hu | Sprint 2 | Form Controls #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Samual-Hu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

London | Jan-26 | Xuanming Hu | Sprint 2 | Form Controls #1132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580aa89
Completed Exercise
Samual-Hu Feb 4, 2026
43c001b
removed spacing lines
Samual-Hu Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 37 additions & 8 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,45 @@
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<form>
Copy link

@iprithv iprithv Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could grouping related inputs using fieldset and legend improve organisation or accessibility here?

<label for="name">What is your name?</label>
<br><br>
Copy link

@iprithv iprithv Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the
elements for spacing here, or might there be another way to control layout?

<input type="text" id="name" name="name" required minlength="2" pattern="[A-Za-z]+([A-Za-z\s]*[A-Za-z]+)*">
Copy link

@iprithv iprithv Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What effect does the name pattern restriction have, could it exclude valid real world names?

<br><br>
<label for="email">What is your email?</label>
<br><br>
<input type="email" id="email" name="email" required>
<br><br>

<label for="colour">Pick a colour</label>
<select id="colour" name="colour" required>
<option value="" disabled selected>Pick a colour</option>
<option value="red">Red</option>
<option value="blue">Blue</option>
<option value="green">Green</option>
</select>

<br><br>

<label for="size">What is your size?</label>
<select id="size" name="size" required>
<option value="" disabled selected>What is your size?</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>

<br><br>

<input type="submit" value="Submit">
</form>
</main>
Copy link

@iprithv iprithv Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any structural elements you could simplify or make more semantic?

<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>By Xuanming Hu</h2>
</footer>
</body>
</html>
Loading