London | Jan-26 | Xuanming Hu | Sprint 2 | Form Controls#1132
London | Jan-26 | Xuanming Hu | Sprint 2 | Form Controls#1132Samual-Hu wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Samual-Hu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Samual-Hu
added
the
Needs Review
iprithv
left a comment
iprithv
left a comment
There was a problem hiding this comment.
Below are some suggestions, if you could look at. Thanks for the submission. The form structure is clear, labels are connected correctly, and validation attributes are being used thoughtfully. Nice work @Samual-Hu
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <form> |
There was a problem hiding this comment.
Could grouping related inputs using fieldset and legend improve organisation or accessibility here?
| </main> | ||
| <form> | ||
| <label for="name">What is your name?</label> | ||
| <br><br> |
There was a problem hiding this comment.
Do you need the
elements for spacing here, or might there be another way to control layout?
| <form> | ||
| <label for="name">What is your name?</label> | ||
| <br><br> | ||
| <input type="text" id="name" name="name" required minlength="2" pattern="[A-Za-z]+([A-Za-z\s]*[A-Za-z]+)*"> |
There was a problem hiding this comment.
What effect does the name pattern restriction have, could it exclude valid real world names?
|
|
||
| <input type="submit" value="Submit"> | ||
| </form> | ||
| </main> |
There was a problem hiding this comment.
Are there any structural elements you could simplify or make more semantic?
iprithv
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Update to html.
Questions
None for now.