Skip to content

Raise on status: Log response data#303

Merged
iLLiCiTiT merged 6 commits intodevelopfrom
enhancement/add-error-logs
Feb 6, 2026
Merged

Raise on status: Log response data#303
iLLiCiTiT merged 6 commits intodevelopfrom
enhancement/add-error-logs

Conversation

@iLLiCiTiT
Copy link
Member

Changelog Description

Log data of failed response.

Additional review information

This is follow up to prematurely merged PR #302 .

Testing notes:

  1. Failed requests should log response data if are available.

@iLLiCiTiT iLLiCiTiT added the type: enhancement New feature or request label Feb 5, 2026
@iLLiCiTiT iLLiCiTiT self-assigned this Feb 5, 2026
@iLLiCiTiT iLLiCiTiT requested a review from BigRoy February 5, 2026 09:26
@iLLiCiTiT iLLiCiTiT changed the title Raise on status: Add debug log with response data Raise on status: Add log response data Feb 5, 2026
@iLLiCiTiT iLLiCiTiT changed the title Raise on status: Add log response data Raise on status: Log response data Feb 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds logging of response data when HTTP requests fail, building on PR #302 which added detail messages to HTTPError responses. The goal is to provide better visibility into why requests fail by logging the complete response data.

Changes:

  • Added logging and json imports to support response data logging
  • Modified RestApiResponse class to include a logger instance
  • Enhanced raise_for_status method to log full response data before raising HTTPRequestError

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iLLiCiTiT iLLiCiTiT merged commit e2a219c into develop Feb 6, 2026
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/add-error-logs branch February 6, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants