chore(claim_contracts): update README#1620
Open
ManuelBilbao wants to merge 3 commits intoyetanotherco:testnetfrom
Open
chore(claim_contracts): update README#1620ManuelBilbao wants to merge 3 commits intoyetanotherco:testnetfrom
ManuelBilbao wants to merge 3 commits intoyetanotherco:testnetfrom
Conversation
ilitteri
approved these changes
Dec 16, 2024
MauroToscano
approved these changes
Dec 16, 2024
Oppen
approved these changes
Dec 16, 2024
JuArce
approved these changes
Dec 16, 2024
Collaborator
JuArce
left a comment
JuArce
left a comment
There was a problem hiding this comment.
I left some comments. But the functionality is ok
| To deploy the token, modify the file `script-config/config.example.json` and set the following values: | ||
|
|
||
| - `safe`: The address of the safe that's going to own the Proxy admin that in turn owns the token and airdrop contracts. | ||
| - `salt`: The salt used to generate CREATE2 addresses. |
Collaborator
There was a problem hiding this comment.
How should the salt be generated?
|
|
||
| - `safe`: The address of the safe that's going to own the Proxy admin that in turn owns the token and airdrop contracts. | ||
| - `salt`: The salt used to generate CREATE2 addresses. | ||
| - `deployer`: The address of the account that's going to deploy the contracts. |
Collaborator
There was a problem hiding this comment.
Specify that deployer must be a CREATE2 deterministic deploy factory
| - `foundation`: The address of the Aligned Foundation account. | ||
| - `claimSupplier`: The address of the account that's going to supply the tokens. | ||
| - `limitTimestampToClaim`: The claim time limit timestamp. | ||
| - `claimMerkleRoot`: The merkle root of all valid token claims. |
Collaborator
There was a problem hiding this comment.
The json file includes claimSupplierPrivateKey. Should we have it?
Contributor
Author
|
I think #1629 already solved this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update README
Description
Updated the README with new deployment instructions using Makefile
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging