feat(operator): DisabledVerifiers Retries#1434
Open
Conversation
PatStiles
changed the title
DisabledVerifeirs RetriesDisabledVerifiers Retries
PatStiles
changed the base branch from
1401-1414-aggregator-retry-improvements
to
staging
PatStiles
force-pushed
the
1415-disabled-verifiers
branch
from
7e896b1 to
59d1c5e
Compare
Oppen
reviewed
Nov 22, 2024
Comment on lines
+97
to
+105
| respondToTaskV2Config := retry.DefaultRetryConfig() | ||
| respondToTaskV2Config.MaxNumRetries = 0 | ||
| respondToTaskV2Config.MaxElapsedTime = 0 | ||
|
|
||
| // Set Retry config for WaitForTxRetryable | ||
| waitForTxConfig := retry.DefaultRetryConfig() | ||
| waitForTxConfig.MaxInterval = 2 * time.Second | ||
| waitForTxConfig.MaxNumRetries = 0 | ||
| waitForTxConfig.MaxElapsedTime = timeToWaitBeforeBump |
Contributor
There was a problem hiding this comment.
Doesn't the MaxNumRetries = 0 mean these won't retry?
Contributor
Author
There was a problem hiding this comment.
There was additional logic added to the retry functions that in the case of 0 retries the function retries indefinitely. This needs to be merged with main we moved these parameters to separate config functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Retry Logic to
DisabledVerifiersDescription
#closes 1415
How to test
In devnet
make anvil_start_with_block_timemake aggregator_startmake operator_full_registration CONFIG_FILE=config-files/config-operator-1.yamlmake operator_start CONFIG_FILE=config-files/config-operator-1.yamlmake batcher_start_localmake telemetry_full_startOnce you have the system running, send proofs
make batcher_send_burst_groth16http://localhost:16686/searchType of change
Checklist