Open
Conversation
johantonelli
approved these changes
Dec 17, 2024
| ;; 'my.app.thing :trace ;; Some namespaces you might want detailed logging | ||
|
|
||
| (defn- decompress-params [{:keys [uri-version] :as query-params}] | ||
| (let [decompress (case uri-version |
Contributor
There was a problem hiding this comment.
It could be more intuitive to be an if if there's only one case with a default (I know, I'm a hypocrite)
Collaborator
Author
There was a problem hiding this comment.
I left it like this because I’ve changed the uri format enough times to know I’ll change it again 😅
mpisanko
force-pushed
the
main
branch
3 times, most recently
from
83ca72e to
a51ddc1
Compare
refset
force-pushed
the
main
branch
6 times, most recently
from
131cee8 to
72c21ab
Compare
refset
force-pushed
the
main
branch
3 times, most recently
from
3f1f430 to
3078315
Compare
Contributor
|
Hey @Akeboshiwind what was your main objective with this? Want to make sure it's added for the right reasons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uri-versionparameterI tested out both lz-string and fflate.
Using gzip with fflate is way smaller than lz-string in around the same time, but when I tried to url encode the output it 10x the output size 😅.