Replace deprecated pipes module with shlex.quote#21
Open
sterliakov wants to merge 1 commit intoxolox:masterfrom
Open
Replace deprecated pipes module with shlex.quote#21sterliakov wants to merge 1 commit intoxolox:masterfrom
pipes module with shlex.quote#21sterliakov wants to merge 1 commit intoxolox:masterfrom
Conversation
|
@sterliakov 👋. Sorry, I looked for a fix for this a couple of weeks ago and your PR didn't exist yet. When I implemented #22 today I didn't check in again before doing so! I'm not sure if @xolox has any desire to maintain 2.7 compatibility but that's the main difference between our two PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipes.quoteis undocumented. It is mentioned in 2.7 docs as deprecated and exported asshlex.quote. Now wholepipesmodule is deprecated as of 3.11 and scheduled for removal in python 3.13.Currently using executor results in a deprecation warning: