Keeps errors returned by libicu prepare (nodexmpp/node-stringprep#65)#69
Open
mdouglass wants to merge 1 commit intoxmppo:masterfrom
Open
Keeps errors returned by libicu prepare (nodexmpp/node-stringprep#65)#69mdouglass wants to merge 1 commit intoxmppo:masterfrom
mdouglass wants to merge 1 commit intoxmppo:masterfrom
Conversation
Only attempt to use the javascript fallback routines when the native libicu function is not available. This fixes two issues: 1) Overwriting the libicu error with a success from the fallback 2) Reporting a LIBICU_NOT_AVAILABLE error when fallbacks are disabled and libicu is present, but returns an error
Author
|
Failure in download? Something transitory? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only attempt to use the javascript fallback routines when the native
libicu function is not available. This fixes two issues:
and libicu is present, but returns an error
Addresses issue #65