Open
Conversation
Contributor
Author
|
The Travis CI build error appears unrelated to my changes. @lloydwatkin, could you please rebuild? |
Contributor
|
@pixelglow done |
Collaborator
|
Is this still relevant? |
Contributor
Author
|
It's been a while since I looked at it! On my current El Capitan system, |
Collaborator
|
If it's really necessary to bundle that much vendor code, could you please update the PR to the files of El Capitan? On the other hand, I've heard that Brew is now that great it was even ported to Linux. Is it working for node-stringprep? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac OS X already has an inbuilt, partial
libicuimplementation calledlibicucore, see e.g. this guide. This pull request buildsnode-stringprepagainst the inbuiltlibicucore, avoiding finicky Homebrew etc. installations oflibicu(see #31, #37, #47).The diffs feature:
unicodeheader directory oflibicuversion 49 from the ICU project. This corresponds to the version on my OS X 10.8 machine and is needed to compile.binding.gypto compile and link againstlibicucore.