do not reuse OpenStack::CLIENT to avoid OOM#140
Closed
jxiaobin wants to merge 1 commit intowoorea:masterfrom
jxiaobin:master
Closed
do not reuse OpenStack::CLIENT to avoid OOM#140jxiaobin wants to merge 1 commit intowoorea:masterfrom jxiaobin:master
jxiaobin wants to merge 1 commit intowoorea:masterfrom
jxiaobin:master
Conversation
|
I do not think you need this heavy means to eliminate the memory leak unless Jersey client leaks. According Jersey's documentation, re-using the same Client shouldn't be a problem. However, the re-registration of the logging filter for WebTarget in JaxRs20Request.request() will be eventually delegated to Client, causing memory leak. I made a pull request for the fix in #139. Fix have been verified with java7/Jersey2.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reuse CLIENT field of com.woorea.openstack.connector.OpenStack in jersey2-connector module will cause OOM issue, I've encountered this in our environment.
This fix will create a new jersey cient every time, and close the client when invocation is done.