Adds a Makefile to improve Bikeshed quality of life.#77
Adds a Makefile to improve Bikeshed quality of life.#77markafoltz wants to merge 1 commit intomainfrom
Conversation
| .PHONY: lint watch | ||
|
|
||
| lint: index.bs | ||
| bikeshed --print=plain --dry-run --force spec --line-numbers $< |
There was a problem hiding this comment.
--force is die on nothing, right? We probably don't want that. What does spec-prod use by default @tabatkins?
There was a problem hiding this comment.
I don't actually know. I assume it always succeeds, aka --force. But for a lint command I definitely think you should use a more restrictive value, that's kinda the point of linting.
Btw --line-numbers no longer does anything, I need to remove that flag. Bikeshed always generates good line numbers now.
There was a problem hiding this comment.
FWIW WebGPU uses DIE_ON=everything in https://github.com/gpuweb/gpuweb/blob/main/spec/Makefile#L12 and https://github.com/gpuweb/gpuweb/blob/main/tools/invoke-bikeshed.sh#L28
There was a problem hiding this comment.
For consistent behaviour between local builds and https://github.com/webmachinelearning/webmcp/blob/main/.github/workflows/auto-publish.yml#L17 we should die on warnings i.e. everything.
There was a problem hiding this comment.
For the lint target we never want to abort processing early and output as many errors/warning as possible in a single pass.
Outputting the spec is optional as lint is a phony target that will always run.
I see that bikeshed now supports --die-when=late. Does that continue processing (even after fatal errors)?
5 participants
Copied from another BS repo.