Conversation
Adds bundled local assets and stops using toolforge to serve assets
Contributor
Author
|
This is currently set |
Contributor
Author
|
To try this out locally one could use this version of skaffold https://github.com/wmde/wbaas-deploy/compare/qs-skaffold?expand=1 |
jakobw
approved these changes
Nov 12, 2021
jakobw
left a comment
jakobw
left a comment
There was a problem hiding this comment.
Looks great to me! My only worry is that it is quite a hefty change which can make it annoying to keep us up to date with upstream changes. It's an acceptable trade-off IMO, so thumbs up!
Also yay for skaffold! Made testing this pretty straightforward. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds local assets and stops using toolforge to serve assets