Conversation
Contributor
Author
|
currently Laravel is not happy with the prepared statement: |
tarrow
reviewed
Apr 25, 2025
| $this->assertDatabaseHas('wiki_daily_metrics', [ | ||
| 'wiki_id' => $activeWiki->id, | ||
| 'date' => Carbon::today()->toDateString() | ||
| 'date' => Carbon::today()->toDateString(), |
Contributor
There was a problem hiding this comment.
We talked about how we could "properly" test this and concluded that this is one of the main weaknesses of this approach. We're so tightly bound to the implementation / layout of mediawiki's private dbs that this isn't really possible to seed with good test data. Hence why this just lives as a null
tarrow
approved these changes
Apr 25, 2025
deer-wmde
added a commit
that referenced
this pull request
Dec 15, 2025
* add areMetricsEqual method * use areMetricsEqual method * add WikiDailyMetricsTest * fix * add db migration * rebase de/dailyMetricsCompare * working query * query * query mediawiki db * typoe hinting * more tyoe hinting * improve test * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T383427
based on #912
Adds data points to WikiMetrics model: