Open
Conversation
- Tested under
- Win10
- GraalVM 21.2.0
- SpigotMC 1.17.1
- Readme updated with instructions on
- how to install using GraalVM instead of OpenJDK
(using GraalJS replacing removed Nashorn JavaScript engine)
- how to build ScriptCraft yourself with Apache Ant
- Solution is not 100% clean as it introduces various
patches to make it work, possibly rolling back some fixes
that are NOT working (any more?) under the above environment
- Includes an out-of-the-box .jar file under 'target' that
you can use directly (no need to build via Ant)
|
Hey! Could you patch your fork to work with GraalVM 21.3.0, Minecraft 1.18 requires JDK 17 |
justinludwig
added a commit
to justinludwig/ScriptCraft
that referenced
this pull request
Dec 9, 2021
justinludwig
added a commit
to justinludwig/ScriptCraft
that referenced
this pull request
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I patched ScriptCraft to work with GraalVM with the GraalJS JavaScript engine.
Tested under Win10, GraalVM R21.2.0, SpigotMC R1.17.1.
Includes instructions in the updated 'ReadMe'.