-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
deps: remove unused rust deps #10688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| rand = { workspace = true } | ||
| rand_chacha = { workspace = true } | ||
| rand_core = { workspace = true } | ||
| sha3 = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interested in replacing sha3 with b3sum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a breaking change for shuf::SeededRng, but open an issue if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes with a forward compatibility commitment: we have to keep using SHA-3 and ChaCha12 and the current (in-tree) algorithms whenever
--random-seedis passed.
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging this PR will degrade performance by 3.16%Comparing Summary
Performance Changes
Footnotes
|
|
No description provided.