Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 3, 2026

No description provided.

rand = { workspace = true }
rand_chacha = { workspace = true }
rand_core = { workspace = true }
sha3 = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interested in replacing sha3 with b3sum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a breaking change for shuf::SeededRng, but open an issue if you like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes with a forward compatibility commitment: we have to keep using SHA-3 and ChaCha12 and the current (in-tree) algorithms whenever --random-seed is passed.

#7585 (comment)

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 3.16%

Comparing xtqqczze:unused-deps (12b383f) with main (d41ed38)1

Summary

❌ 1 regressed benchmark
✅ 283 untouched benchmarks
⏩ 38 skipped benchmarks2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cp_large_file[16] 369.5 µs 381.5 µs -3.16%

Footnotes

  1. No successful run was found on main (1ea01a3) during the generation of this report, so d41ed38 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 3, 2026

---- test_dd::test_final_stats_less_than_one_kb_si stdout ----
bin: "/target/x86_64-unknown-linux-gnu/debug/coreutils"
run: /target/x86_64-unknown-linux-gnu/debug/coreutils dd

thread 'test_dd::test_final_stats_less_than_one_kb_si' panicked at tests/uutests/src/lib/util.rs:412:35:
called `Option::unwrap()` on a `None` value

#10455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants