Skip to content

Conversation

@aaron-ang
Copy link
Contributor

@aaron-ang aaron-ang commented Feb 2, 2026

Fix part of #2320.

@aaron-ang aaron-ang force-pushed the more-options branch 2 times, most recently from fa90357 to 4274f7b Compare February 3, 2026 00:23
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

Merging this PR will not alter performance

✅ 284 untouched benchmarks
⏩ 38 skipped benchmarks1


Comparing aaron-ang:more-options (80615dc) with main (5df49ac)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@aaron-ang aaron-ang force-pushed the more-options branch 2 times, most recently from ca5cb85 to bbe07a0 Compare February 3, 2026 16:31
@sylvestre
Copy link
Contributor

please split this PR into several

@aaron-ang aaron-ang changed the title feat(more): logical, exit_on_eof, no_pause options feat(more): exit_on_eof option Feb 3, 2026
@aaron-ang
Copy link
Contributor Author

aaron-ang commented Feb 3, 2026

@sylvestre this PR now covers exit_on_eof option only, with some minor refactoring on existing structs and tests. Once this is merged, I will add the remaining option implementations (logical and no_pause)

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants