Sort: improve the code after recent changes #10647
Draft
+43
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
xtqqczze
reviewed
Feb 2, 2026
|
|
||
| for (idx, selector) in settings.selectors.iter().enumerate() { | ||
| let key_index = idx + 1; | ||
| let key_index = idx.saturating_add(1); |
Contributor
There was a problem hiding this comment.
enumerate() itself doesn’t guard against overflow, so guarding only at idx + 1 doesn’t add real safety.
In any case, I think idx.checked_add(1).unwrap() would make more sense.
Contributor
There was a problem hiding this comment.
Hang on, there is no potential overflow, key_index has the range 1..settings.selectors.len()
They all optimise to the same anyway: https://godbolt.org/z/f4WzhP1vf
xtqqczze
reviewed
Feb 2, 2026
| @@ -1800,7 +1803,7 @@ fn emit_debug_warnings( | |||
| show_error!("{}", translate!("sort-warning-simple-byte-comparison")); | |||
|
|
|||
| for (idx, selector) in settings.selectors.iter().enumerate() { | |||
Contributor
There was a problem hiding this comment.
Suggested change
| for (idx, selector) in settings.selectors.iter().enumerate() { | |
| for (key_index, selector) in (1..).zip(settings.selectors.iter()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #9848