Replace PHPStan ignores with jetbrains/phpstorm-stubs for Redis Streams#65
Draft
Copilot wants to merge 2 commits intofeat-redis-streamsfrom
Draft
Replace PHPStan ignores with jetbrains/phpstorm-stubs for Redis Streams#65Copilot wants to merge 2 commits intofeat-redis-streamsfrom
Copilot wants to merge 2 commits intofeat-redis-streamsfrom
Conversation
Draft
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: abnegate <5857008+abnegate@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix feedback on Redis Streams by resolving root cause
Replace PHPStan ignores with jetbrains/phpstorm-stubs for Redis Streams
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan was reporting undefined method errors for Redis Streams methods (xAdd, xGroup, xReadGroup, etc.) because the default PHP extension stubs lack these definitions. This was being suppressed with ignoreErrors.
Changes
jetbrains/phpstorm-stubsas dev dependency - provides complete type definitions for Redis Streams methods on RedisClusterThis ensures proper static analysis for Redis Streams operations without suppressing legitimate type checking.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.