Conversation
📝 WalkthroughWalkthroughThe change enhances the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/Database/Database.php`:
- Around line 2669-2684: The TEXT branch currently skips validation but leaves a
prior or supplied $size intact, causing stale metadata; in the case handling
self::VAR_TEXT, self::VAR_MEDIUMTEXT, and self::VAR_LONGTEXT ensure $size is
normalized (e.g., set to null/zero or rejected) before continuing so it cannot
be persisted or used for width/index checks—update the switch branch in the
method where $size is inspected (the case blocks for self::VAR_TEXT /
VAR_MEDIUMTEXT / VAR_LONGTEXT) to either assign a normalized value to $size or
throw a DatabaseException when a non-empty size is provided, so downstream logic
never sees a leftover VARCHAR size.
Summary by CodeRabbit
Release Notes