WIP POC for better perf with encode/decode/castings#735
WIP POC for better perf with encode/decode/castings#735ItzNotABug wants to merge 7 commits intooptimize-relsfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Can you update the description to explain a bit more about the change? From looking through I can't tell where the improvement comes from
Edit: just saw that we're doing casting/decode in a single loop instead of separately. IMO this solution is a bit overkill, we're adding 1.5K lines of code to reduce 2 loops to 1, I'm not opposed to tightening the looping, but I think it could be a lot simpler
Add single-pass document processor for faster reads by combining decode and casting into one pass instead of two, reducing overhead when reading documents. Enabled via DB_SINGLE_PASS_PROCESSOR env var with fallbacks for edge cases. Includes benchmarks to test via
DB_SINGLE_PASS_PROCESSOR.