Fix golangci-lint warnings for most files#463
Open
ChetanFTW wants to merge 1 commit intourunc-dev:mainfrom
Open
Fix golangci-lint warnings for most files#463ChetanFTW wants to merge 1 commit intourunc-dev:mainfrom
ChetanFTW wants to merge 1 commit intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
Contributor
|
Hello @ChetanFTW , thank you for the fixes. Overall, it would better to wait for an issue to get verified before opening a PR. As I mentioned in the issue, urunc already makes use of We are exploring which linters and formatters to enable and I would suggest to revisit this when we integrate the linters and formatters in our CI, so we can automatically check against new changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 97 linting warnings reported by golangci-lint.
✅ Changes made:
No functional changes were made; this PR is purely for improving code quality and readability, making the repo more Go-best-practices compliant.
Related issues
Fixes #462
How was this tested?
Before:
After:
Remaining:
**** 61 warnings remain ****