tests: add Firecracker edge-case unit tests#461
Open
ChetanFTW wants to merge 1 commit intourunc-dev:mainfrom
Open
tests: add Firecracker edge-case unit tests#461ChetanFTW wants to merge 1 commit intourunc-dev:mainfrom
ChetanFTW wants to merge 1 commit intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
Contributor
|
Hello @ChetanFTW , thank you for this PR, please read the urunc's contribution guide and fill correctly the form in the PR. Also, this PR has similar changes with #397 and since #397 is almost ready for merging, this PR should get adapted to it after its merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for Firecracker config builder (initrd selection, memory defaulting, vsock and networking). Extracts a helper to build the JSON config so it can be unit-tested without execve side-effects.