fix(utils): perform extra handling of QueueProxy container#451
Open
ishaanxgupta wants to merge 1 commit intourunc-dev:mainfrom
Open
fix(utils): perform extra handling of QueueProxy container#451ishaanxgupta wants to merge 1 commit intourunc-dev:mainfrom
ishaanxgupta wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Add extra check in handleQueueProxy() so it only appends readinessProbeEnv when it’s non-empty. Fixes urunc-dev#419 Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
Author
|
@cmainas please have a look |
Contributor
|
Hello @ishaanxgupta , could you also set up a knative environment and test this out? You can find a tutorial here https://urunc.io/tutorials/knative/ |
Contributor
Author
Hi @cmainas I had already completed the setup and tested on it, will share the testing screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add extra check in handleQueueProxy() so it only appends readinessProbeEnv when it’s non-empty.
Related issues
Fixes #419
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).