Added correct typing for has one create mixin values.#189
Open
Ranguna wants to merge 1 commit intotypes:masterfrom
Open
Added correct typing for has one create mixin values.#189Ranguna wants to merge 1 commit intotypes:masterfrom
Ranguna wants to merge 1 commit intotypes:masterfrom
Conversation
Author
|
Also, I just realized that I have a typo in the commit message, I can redo the commit if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone!
I'm trying to make a wrapper around sequelize mixins and I stumbled upon this.
If I understood the mixing correctly, the
createModelmixin forhasOneassociation does not seem to have the correct typing for the creation values (accessible from Model["_creationAttributes"]).Do these changes make sense ?
If yes, I can replicate them to all other association types.