Use configureCabalFlags from cabal2nix#69
Open
jcpetruzza wants to merge 3 commits intotypeable:masterfrom
Open
Use configureCabalFlags from cabal2nix#69jcpetruzza wants to merge 3 commits intotypeable:masterfrom
jcpetruzza wants to merge 3 commits intotypeable:masterfrom
Conversation
The function `configureCabalFlags` has a list of packages that should be called with certain flags when passing them to `cabal2nix`. For example, for `hslua`, it specifies that it is to used the "system" version of lua (the one provided by nix) and not the version of lua that comes embedded in the package. Notice that cabal2nix assumes assumes this flag in newer versions of its `postProcess` method, and if the flag is not given, it will fail attempting to replace package "lua" by "lua_5_3".
Adds a `nix` section in the stack.yaml, as an `opt-in`, so it shouldn't break previous behaviour.
Author
|
I see the checks failed, but as far I can see, this is unrelated to my changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
configureCabalFlagsuses a list of packages that should be called with certain flags when passing them tocabal2nix.For example, for
hslua, it specifies that it is to used the "system" version of lua (the one provided by nix) and not the version of lua that comes embedded in the package. Notice that cabal2nix assumes assumes this flag in newer versions of itspostProcessmethod, and if the flag is not given, it will fail attempting to replace package "lua" by "lua_5_3". In any case, a derivation forhsluathat doesn't includelua_5_3as a dependency would be incomplete.This PR also contains two minor changes (they could be moved to a different PR if needed):
stackage2nixwork with more recent versions ofcabal2nix, which introduced a couple of api-breaking changes.stack --nix.