Conversation
Add the .. operator to the VM with Lua's number-to-string coercion semantics. Fixes the codegen to emit proper two-register operands and adds the executor handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up the
..operator end-to-end. The codegen was already emitting a:concatenateinstruction but with the wrong shape (assumed consecutive registers) and the executor had no handler for it. This fixes the instruction to use two explicit source registers like every other binary op, and adds the executor handler with Lua's number-to-string coercion (1 .. 2→"12").Progress