[pull] master from ruby:master#755
Merged
pull[bot] merged 10 commits intoturkdevops:masterfrom Feb 7, 2026
Merged
Conversation
(ruby/prism#3910) * Update C call seqs * Prefixing them with self is unusual * Also use `.` instead of `::` to refer to class methods * Capitalize location in docs It allows it to be linked to in docs * Miscelanous other doc tweaks * Format code as code * Nodoc some missed methods * Fix method reference * Really try to nodoc ffi module The previous approach was wrong, to nodoc the class methods it must be specified at the module itself. As a result, the private methods like `dump_options` are also removed. * Remove some def-style comments They are mostly redundant with the method signature and don't look great when rendered. Still remaining on nodes. I will improve docs for them in a separate PR ruby/prism@94e5525521
When removing a thread from `running_threads`, if we're on a shared native thread and we're running a dedicated task, we need to wake the timer thread so it can create a new SNT if necessary. We only do this if it's waiting forever without the 10ms quantum timeout for now, because max 10ms of wait is considered "good enough". In the future, perhaps we can force the timer thread to wake if this becomes an issue (`timer_thread_wakeup_force`). Fixes [Bug #21504]
The `Rice` C++ library uses an Anchor class that uses RAII to call `rb_gc_register_address`, `rb_gc_unregister_address` during init+destruct. It's unclear if this API is meant to be used at runtime like this, but we can at least lock the VM so it works safely across Ractors and doesn't mangle the `global_object_list` table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )